Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] using DOMAIN_SUFFIX breaks netbox links in Geomap #2239

Closed
mirkobern opened this issue Dec 17, 2020 · 1 comment
Closed

[BUG] using DOMAIN_SUFFIX breaks netbox links in Geomap #2239

mirkobern opened this issue Dec 17, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@mirkobern
Copy link

Describe the bug

I configured 'DOMAIN_SUFFIX = .ucman.local'

When in Geomap i select a room with the netbox 'bastion.ucman.local' in it, it's shown with a link named 'bastion' (correctly shortened) but the href of the link points to 'http://navapp.ucman.local/ipdevinfo/bastion/' (also shortened) and clicking it the response page goes:
'bastion
Device Info
IP Address: N/A
Status Not monitored'

if i search 'bastion' in the global search it is correctly redirected to 'http://navapp.ucman.local/ipdevinfo/bastion.ucman.local/'

not knowing the code behind I suppose the simplest solution is that the href of links shouldn't be shortened, only the name

To Reproduce
Steps to reproduce the behavior:
1 Configure the DOMAIN_SUFFIX
2 Go to Geomap and select a room
3 on the room popup look to a netbox shortened name link
4 click on the link and see if it arrive to the correct page

Expected behavior
selecting a netbox link on geomap should bring up the correct ipdevinfo page

Environment (please complete the following information):
client side: Firefox 83 (64bit) on ubuntu 18.0.4
server: Debian 10 nav 5.1.1
Method of installation from Debian package

@lunkwill42 lunkwill42 added the bug label Jan 15, 2021
@lunkwill42 lunkwill42 self-assigned this Jan 15, 2021
@lunkwill42 lunkwill42 added this to the 5.1.2 milestone Jan 15, 2021
@lunkwill42 lunkwill42 changed the title [BUG] using DOMAIN_SUFFIX broke netbox links in Geomap [BUG] using DOMAIN_SUFFIX breaks netbox links in Geomap Jan 15, 2021
@lunkwill42
Copy link
Member

Thanks again for the bug report. Looks like a quick fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants