-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to admin page #553
Conversation
2f0c73e
to
e0c56fa
Compare
5c80469
to
571e87b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks great, I really like the new design with the icons and the horizontal divider.
My only problem is the fact that the admin_url
is an absolute url and I think you're treating it as a relative url, which results in if I get admin_url: http://localhost:8000/admin/
then the link I'm clicking on is http://localhost:8080/http://localhost:8000/admin/, which interestingly enough first gave me a 404 error, but now actually leads me to the admin.
But it still should only link to the admin_url exactly how it's received.
Only visible for users who have admin urls
Better accessibility
Also makes it easier to test the components
571e87b
to
325fa83
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #553 +/- ##
==========================================
- Coverage 57.30% 57.29% -0.02%
==========================================
Files 86 86
Lines 3687 3693 +6
Branches 835 817 -18
==========================================
+ Hits 2113 2116 +3
- Misses 1565 1568 +3
Partials 9 9 ☔ View full report in Codecov by Sentry. |
Since admin_url it is always an absolute URL
For better accessibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Tested both with an admin account and a normal account and all works as expected!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Closes #537