Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove groovy/spock dependencies #1188

Closed
tdrwenski opened this issue May 23, 2023 · 0 comments · Fixed by #1334
Closed

Remove groovy/spock dependencies #1188

tdrwenski opened this issue May 23, 2023 · 0 comments · Fixed by #1334

Comments

@tdrwenski
Copy link
Contributor

tdrwenski commented May 23, 2023

Overview

There are currently 18 .groovy files that have Spock tests in NetCDF-java. These should be converted to JUnit tests and then the dependencies on groovy and spock should be removed from the gradle build files. Some tests may need to to be altered because you can test private methods with Spock but not with JUnit.

Files

To convert:

./cdm/core/src/test/groovy/ucar/nc2/ft2/coverage/HorizCoordSysCrossSeamBoundarySpec.groovy
./cdm/core/src/test/groovy/ucar/nc2/ft2/coverage/writer/CFGridCoverageWriter2Spec.groovy
./cdm/core/src/test/groovy/ucar/nc2/ft2/coverage/HorizCoordSysGisTextBoundarySpec.groovy
./cdm/core/src/test/groovy/ucar/nc2/util/cache/ReacquireClosedDatasetSpec.groovy
./cdm/core/src/test/groovy/ucar/nc2/ncml/LogicalViewsSpec.groovy
./cdm/core/src/test/groovy/ucar/nc2/ncml/NcMLWriterSpec.groovy
./cdm/core/src/test/groovy/ucar/nc2/ncml/CacheAggregationsSpec.groovy
./cdm/core/src/test/groovy/ucar/nc2/iosp/netcdf3/N3iospSpec.groovy
./cdm/core/src/test/groovy/ucar/nc2/ft/point/FlattenedDatasetPointCollectionSpec.groovy
./cdm/core/src/test/groovy/ucar/nc2/ft/point/PointIteratorFilteredSpec.groovy
./cdm/core/src/test/groovy/ucar/nc2/ft/point/remote/PointStreamSpec.groovy
./netcdf4/src/unloadedTest/groovy/ucar/nc2/jni/netcdf/UnloadedNc4IospSpec.groovy
./netcdf4/src/test/groovy/ucar/nc2/jni/netcdf/Nc4IospSpec.groovy
./netcdf4/src/test/groovy/ucar/nc2/jni/netcdf/Nc4IospMiscSpec.groovy

These tests are testing no longer used legacy code and so can just be removed:

./legacy/src/test/groovy/thredds/crawlabledataset/s3/ThreddsS3ClientImplSpec.groovy
./legacy/src/test/groovy/thredds/crawlabledataset/s3/CachingThreddsS3ClientSpec.groovy
./legacy/src/test/groovy/thredds/crawlabledataset/s3/CrawlableDatasetAmazonS3Spec.groovy
./legacy/src/test/groovy/thredds/crawlabledataset/s3/S3URISpec.groovy

UnloadedNc4IospSpec may be a good one to start with as it does not look too complicated.

@tdrwenski tdrwenski changed the title Remove groovy/spock dependency Remove groovy/spock dependencies May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant