BUG: Fixup geopotential<->height calculation (Fixes #1075) #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Area: Calc
|
Borrowing from @sgdecker 's example in #1075, here's the change by this PR: Before
After
|
zbruick
previously approved these changes
Jul 3, 2019
dopplershift
force-pushed
the
geopotential
branch
from
e082085 to
aad4528
Compare
Previous implementations was a naive implementation that directly translated formulas from source material. It included a lot of division and subtraction, resulting in catastrophic cancellation and severe loss of floating point precision. New formulation is just an algebraic reformulation that avoids these problems.
dopplershift
force-pushed
the
geopotential
branch
from
aad4528 to
7470c4b
Compare
zbruick
approved these changes
Jul 5, 2019
|
Merging over skewT failures. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementations was a naive implementation that directly translated formulas from source material. It included a lot of division and subtraction, resulting in catastrophic cancellation and severe loss of floating point precision. New formulation is just an algebraic reformulation that avoids these problems.
In fixing #1075, I went ahead and refactored
height_to_geopotentialas well to address similar problems with floating point precision.