Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SkewT and Hodograph plotting tests with xarray and fix uncovered bugs #1752

Open
jthielen opened this issue Mar 5, 2021 · 1 comment
Labels
Area: Plots Pertains to producing plots Area: Units Pertains to unit information Area: Xarray Pertains to xarray integration Type: Maintenance Updates and clean ups (but not wrong)

Comments

@jthielen
Copy link
Collaborator

jthielen commented Mar 5, 2021

I haven't been able to come to a quick resolution to #1749, but did notice/recall along the way that xarray support doesn't really seem to have been tested or considered for MetPy's custom plot types (SkewT and Hodographs). With xarray being the suggested/primary data model now in metpy.calc for MetPy 1.0, these really should be supported as first-class data objects throughout metpy.plots as well.

In some brief notebook investigations, some things "just worked" as long as unit conversions were performed, and others (particularly cape/cin shading) failed completely, so there will be more work than just adding tests.

@jthielen jthielen added Type: Maintenance Updates and clean ups (but not wrong) Area: Plots Pertains to producing plots Area: Xarray Pertains to xarray integration labels Mar 5, 2021
@jthielen
Copy link
Collaborator Author

jthielen commented Mar 5, 2021

Not sure to what extent we need to support it, or if it is something that needs to be handled upstream in Pint, xarray, and/or matplotlib, but based on #1749 we should probably also test what happens when mixing xarray and pint objects in SkewT and Hodograph calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Plots Pertains to producing plots Area: Units Pertains to unit information Area: Xarray Pertains to xarray integration Type: Maintenance Updates and clean ups (but not wrong)
Projects
None yet
Development

No branches or pull requests

1 participant