-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REDESIGN] performance compared to 1.8.1 #126
Comments
So the latest release (https://github.com/UnicordDev/Unicord/releases/tag/v2.0.0-alpha.11) has made some additional improvements to app launch times, if you want to re-test! |
Also worth noting, try to test at similar times of day, a lot of Unicord's launch time is just down to how long Discord takes to send the READY payload which can depend on their server load |
I was testing responsiveness from tapping a channel icon on 2.x vs. tapping the hamburger button on 1.8.x, so the responsive times after launch are likely incorrect. Lumia 635, v2.0.40:
Lumia 635, v1.8.1:
Yup, when I do comparison tests I do them immediately after. Usually Unicord 2.x first to give it the best opportunity in case leftovers from the previous instance didn't close out cleanly or etc. I think performance, or perceived performance, at this rate is more of design decisions, namely loading a channel immediately upon tapping a guild instead of showing its channel list first (which is far faster). I'll make a separate issue to request readding this functionality to 2.x. However, when I did have both apps suspended in tablet mode on Windows 10 (4GB ram, 1st gen Surface Go, to search for a screen recorder for a different issue), only 2.x crashed after some time. They were both on the same channel but will take me some time to reproduce the "resiliency" of the app in constrained resources. |
good to see those specific optimisations paid off! |
Not sure if you want me to break these out into separate issues or just keep all findings/records here.
I did not monitor performance metrics during these tests.
The devices I've tested on are:
App launch:
Interestingly, the following metrics, in my experience would consistently take longer with 2.0.27, but this is not the case when doing these tests this evening. I wonder if this correlates with less activity and thus not impacting the different way events are handled in 2.0? Not entirely sure. My experience has been more of 4-6 seconds with channel switches with 2.0. Given that I did these tests shortly after app launch, maybe this changes after the app has been running for a while...
Switching DMs:
I ensure the DM has been loaded (opened up) before measuring.
Switching channels:
I ensure the channel has been loaded (opened up) before measuring.
The text was updated successfully, but these errors were encountered: