Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend 3: Pull Screenshots from Entry Points #782

Merged
merged 5 commits into from
Nov 9, 2021
Merged

Conversation

geringsj
Copy link
Contributor

@geringsj geringsj commented Apr 19, 2021

Adds mmScreenshotEntryPoint(view, filename) to write result images of entry point views as screenshots.

Summary of Changes

  • Refactors Screenshot Service, pass Screenshot data as const&
  • Adds byte_texture and ImageWrapper->byte_texture conversion
  • Writes byte_texture to screenshots
  • Provides mmScreenshotEntryPoint(view, filename) for Lua scripting

References and Context

This pulls screenshots directly from entry points, ignoring the GUI overlay. Also enables screenshots of arbitrary size when entry point rendering gets decoupled from the GLFW window resolution. mmScreenshotEntryPoint(view, filename) can be condensed to simply mmScreenshot(filename [, view]) when at some point the Lua Lambda Callbacks allow for optional arguments.

Test Instructions

Load your project and execute mmScreenshotEntryPoint(view, filename) via Lua, either in a project file or via remote console.

@geringsj geringsj marked this pull request as draft April 19, 2021 23:58
@geringsj geringsj force-pushed the frontend_images3 branch 2 times, most recently from f740bee to 7c83cfe Compare November 8, 2021 16:24
@geringsj geringsj marked this pull request as ready for review November 9, 2021 13:03
@geringsj geringsj requested review from braunms and tobiasrau November 9, 2021 13:04
@tobiasrau tobiasrau merged commit ad5a075 into master Nov 9, 2021
@tobiasrau tobiasrau deleted the frontend_images3 branch November 9, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants