Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended RuntimeInfo #1230

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Extended RuntimeInfo #1230

wants to merge 8 commits into from

Conversation

gralkapk
Copy link
Member

@gralkapk gralkapk commented Oct 9, 2023 •
edited
Loading

  • RuntimeInfo Service
  • Windows Extended RuntimeInfo
  • Linux Extended RuntimeInfo

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Style check found formatting issues! Comment /format, to automatically commit the suggested changes.

@gralkapk
Copy link
Member Author

gralkapk commented Oct 9, 2023

/format

MegaMol-Bot and others added 2 commits October 9, 2023 14:55
moritz-h
moritz-h reviewed Apr 17, 2024
View reviewed changes
core/include/mmcore/utility/platform/RuntimeInfo.h
return gpu_;
}

static std::string GetOSInfo() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference to GetOsInfo, do we really need this twice or can one be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moritz-h moritz-h moritz-h left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gralkapk @moritz-h