Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light ImGUI GUI Style Themes Should Affet Default View Background Color Too? #1066

Open
geringsj opened this issue Jun 23, 2022 · 1 comment
Assignees
Labels

Comments

@geringsj
Copy link
Contributor

When setting a light UI theme, View backgrounds should also be affected? How could we make one single "view default bg color" work, which either the user or the UI can configure? How would this interact with project files which bring an explicit background color value for each view with them?

@geringsj geringsj added the bug label Jun 23, 2022
@braunms braunms self-assigned this Jun 23, 2022
@moritz-h
Copy link
Member

Idea:
Use a global theme color table. Define an enum of around 7-10 theme entries (quick idea: "background", "primary", "secondary", "highlight", "selection", "text", "interface/UI") and store a global theme color for each entry. A few presets for all colors could maybe be predefined, matching the imgui style bright or dark.

For access use a ThemedColorParam. UI of this param has a combobox with the enum entries. I.e. the view can then use this ThemeColorParam for the background and initialize it with ThemeColor::Background.
The color param only stores the enum value, not an actually color, just look it up in the global table when using getColor(). Therefore no event handling for changes is needed.
Further an "custom" option would be great in the combobox, to basically force the ThemedColorParam to be an classical one with fully custom color override.

(maybe we also do not really need a new ThemedColorParam and can add this kind of functionality to the regular ColorParam instead)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants