Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The undo feature (Ctrl+Z) of the code editor can replace the code from another tab. #1149

Closed
VladiStep opened this issue Jan 8, 2023 · 0 comments · Fixed by #1148
Closed
Labels
bug Something isn't working

Comments

@VladiStep
Copy link
Member

VladiStep commented Jan 8, 2023

Describe the bug

The undo history could contain the entire code from the previously opened code tab if you switch between "Decompiled" and "Disassembly" mode tabs.
This happens because DecompiledYet/DisassembledYet is not reset to false on switching between code tabs, and also because the UndoStack is listening for changes even on the document fill stage.

Reproducing steps

  1. Open two code tabs.
  2. Switch to "Disassembly" tab of the first code tab.
  3. Switch to the second code tab.
  4. Switch back to "Decompiled" tab.
  5. Press Ctrl+Z.

Here's a video which demonstrates the both cases:

bandicam.2023-01-08.21-43-56-866.mp4

Setup Details

  1. UTMT version - 3cc23d9
@VladiStep VladiStep added the bug Something isn't working label Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant