Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BadgerBOT mis-returning quotes #246

Open
FauxFaux opened this issue Aug 22, 2011 · 6 comments
Open

BadgerBOT mis-returning quotes #246

FauxFaux opened this issue Aug 22, 2011 · 6 comments

Comments

@FauxFaux
Copy link
Member

See this conversation in PM:
{{{
13:31:37 Laurence|Tov >> getquote 3812
13:31:37 BadgerBOT >> zx64|HoG: What are you doing here? One at a time we agreed!
13:31:37 BadgerBOT >> zx64|HoG: Just get out of here before the space-time continuum notices.
}}}
{{{
13:31:48 Laurence|Tov >> getquote 3812
13:31:50 BadgerBOT >> zx64|HoG: What are you doing here? One at a time we agreed!
13:31:50 BadgerBOT >> zx64|HoG: Just get out of here before the space-time continuum notices.
}}}
{{{
13:32:01 Laurence|Tov >> jb getquote 3812
13:32:02 BadgerBOT >> <zx64|HoG> It's my turn bitch
13:32:03 BadgerBOT >> zx64|HoG: Just get out of here before the space-time continuum notices.
13:32:03 BadgerBOT >> zx64|HoG: What are you doing here? One at a time we agreed!
}}}
{{{
13:32:06 Laurence|Tov >> jb getquote 3812
13:32:08 BadgerBOT >> zx64|HoG: What are you doing here? One at a time we agreed!
13:32:08 BadgerBOT >> <zx64|HoG> It's my turn bitch
13:32:08 BadgerBOT >> zx64|HoG: Just get out of here before the space-time continuum notices.
}}}

The last one of the JB requests is correct quote. (JB's mis-return of the quote is due to bug #182 (passthru.send returns messages in the wrong order)). For some reason BadgerBOT is leaving out an entire line in the quote.

@FauxFaux
Copy link
Member Author

Author: faux
Cleanup the desc.

@FauxFaux
Copy link
Member Author

Author: faux
And, this doesn't appear to be a bug with the bot, the line is missing from the database (despite the fact that the line-numbers agree there should be an extra line):

{{{
id quoteid line nick text action?
5063 3812 1 zx64 zx64|HoG: What are you doing here? One at a time w... 0
5065 3812 3 zx64 zx64|HoG: Just get out of here before the space-ti... 0
}}}

The line that'd be expected to be the middle line is:
{{{
5064 0 0 0
}}}

Transition error?

@FauxFaux
Copy link
Member Author

Author: faux
By the wonders of SQL HAX, it has been determined that (at least) 3132, 3812, 3775 and 6949 have been mis-copied, and there are 14 "corrupt" lines (ie. with a quoteid of 0).

For reference:
{{{
SELECT quoteid,count(linenumber)-max(linenumber) as diff FROM _objectdb_plugins_quote_quoteline where quoteid < 9536 GROUP BY quoteid having diff!=0; SELECT quoteid,count(linenumber)-max(linenumber) as diff FROM _objectdb_plugins_quote_quoteline where quoteid >= 9536 GROUP BY quoteid having diff!=1;
}}}

@FauxFaux
Copy link
Member Author

Author: faux
It seems that all the quotes that have been mis-copied are invalid, ie. contain |s.

Are we going to allow such evilness?

@FauxFaux
Copy link
Member Author

Author: silver
Having a | in the nick is not invalid. It actually makes some of the older quotes ''work''.

@FauxFaux
Copy link
Member Author

Ticket imported from Trac:
http://trac.uwcs.co.uk/choob/ticket/246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant