This repository has been archived by the owner on May 4, 2022. It is now read-only.
Update crest image so it works with all themes #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't affect me. Still LGTM 👍 |
|
do we serve an optimized version of the logo, or do we just cram that png into 56 pixels? |
apetro
approved these changes
Apr 27, 2017
vertein
approved these changes
Apr 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the fervor to update to a shiny new thing, I neglected to check whether the necessary new CSS in #413 would affect other themes' crest images. In order to get a higher quality UW-Madison image that looks good, follows brand standard, and doesn't break other theme crests, I had to switch to a slightly adjusted PNG version of the one from brand.wisc.edu.
This is a change in style from the overflowing crest of old.
Screenshots