This repository has been archived by the owner on May 4, 2022. It is now read-only.
MUMUP-2875 Fixes bug with dataObject in notification feed caused it to not display #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianMurphy
approved these changes
Mar 30, 2017
| return notification; | ||
| } | ||
| } else if (objectToFind) { | ||
| return notification |
There was a problem hiding this comment.
🎨 should the return statement be closed with a semicolon?
There was a problem hiding this comment.
I don't know how I could have missed that!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the data object to find to show notification would return but we were checking if length > 0. Well, length>0 is only valid when it's an array, so if it was just an object, it would fail and not show the notification. Added test case as well.
Contributor License Agreement adherence: