Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

Clarify in CONTRIBUTING.md that Google Style. #630

Merged
merged 3 commits into from
May 22, 2017
Merged

Clarify in CONTRIBUTING.md that Google Style. #630

merged 3 commits into from
May 22, 2017

Conversation

apetro
Copy link
Contributor

@apetro apetro commented May 19, 2017

We've spiritually adopted Google Style, albeit in practice imperfectly and with imperfect automated checking.

Note this spirit in CONTRIBUTING.md to help all Contributors to know the project's intended style.

You've either got or you haven't got style.


Copy link
Contributor

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major 👍 🌟
LGTM

Thanks @apetro!

@ChristianMurphy
Copy link
Contributor

@apetro FWIW there's also a badge for that 🙂
Google Code Style

[![Google Code Style](https://img.shields.io/badge/code_style-Google-green.svg?style=flat)](https://google.github.io/styleguide/jsguide.html)

@apetro apetro merged commit ffdf622 into master May 22, 2017
@apetro apetro deleted the google-style branch May 22, 2017 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants