This repository has been archived by the owner on May 4, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
Add jsdoc for filteredArray widget function #611
Merged
thevoiceofzeke
merged 8 commits into
uPortal-Attic:master
from
thevoiceofzeke:filteredArray
Apr 11, 2017
Merged
Add jsdoc for filteredArray widget function #611
thevoiceofzeke
merged 8 commits into
uPortal-Attic:master
from
thevoiceofzeke:filteredArray
Apr 11, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vertein
approved these changes
Apr 11, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate TODO's in code...
ChristianMurphy
approved these changes
Apr 11, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
👍 for JSDocs in general
* @param array The array to filter | ||
* @param objectVar The array entry to search through | ||
* @param strings The string values to test against each entry | ||
* @returns {*} An array containing only the desired |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe jsdoc type annotations could help?
/**
* @param {Array<Object>} array The array to filter
* @param {Object} objectVar The array entry to search through
* @param {Array<String>} strings The string values to test against each entry
* @returns {Array<Object>} An array containing only the desired
*/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found something that uses this function while editing entity files -- figured I should explain why it's in this controller in the first place!