This repository has been archived by the owner on May 4, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
MUMUP-2886 adding name transitions and descriptions #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianMurphy
approved these changes
Mar 31, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
+ Names should reflect uPortal commitment and represent how the product should | ||
be used. | ||
+ Proposed names: | ||
+ `uw-frame` → `uPortal-app-framework` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
+ Institutions can provide a custom `uPortal-app-framework-config` | ||
+ Developers can create their own uPortal Apps drawing from common | ||
configuration, style and functionality. | ||
+ `angularjs-portal` → `uPortal-home` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-0
Good question in the uportal-dev thread: https://groups.google.com/a/apereo.org/forum/#!topic/uportal-dev/BXOjNeuTC7E Why uPortal Home? |
vertein
approved these changes
Mar 31, 2017
thevoiceofzeke
approved these changes
Mar 31, 2017
apetro
approved these changes
Apr 3, 2017
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing project name changes for incubation
Contributor License Agreement adherence: