Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

Guide Contributors to Apereo ICLA compliance #592

Merged
merged 4 commits into from
Mar 21, 2017
Merged

Guide Contributors to Apereo ICLA compliance #592

merged 4 commits into from
Mar 21, 2017

Conversation

apetro
Copy link
Contributor

@apetro apetro commented Mar 16, 2017

  • Document requirement in CONTRIBUTING.md.
  • Add ICLA-adherence checkbox to pull request template.

@apetro
Guide Contributors to Apereo ICLA compliance
965212c 
Document requirement in CONTRIBUTING.md.
Add ICLA-adherence checkbox to pull request template.
@coveralls
Copy link

coveralls commented Mar 16, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 15.768% when pulling 965212c on require-icla into 1bccc2f on master.

ChristianMurphy
ChristianMurphy approved these changes Mar 17, 2017
View reviewed changes
Copy link
Contributor

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/PULL_REQUEST_TEMPLATE.md Outdated

<!-- Place an x in the checkbox spot to indicate YES. -->

- [ ] This Contribution is under the terms of [Individual Contributor License Agreement(s) (and also Corporate Contributor License Agreement(s)][Apereo Contributor License Agreements] to the extent applicable) appearing in the [Apereo CLA roster][].
Copy link
Contributor

@ChristianMurphy ChristianMurphy Mar 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could using markdown link shorthand make this more readable?

- [ ] This Contribution is under the terms of [Individual Contributor License Agreement][](s) (and also Corporate Contributor License Agreement(s) to the extent applicable) appearing in the [Apereo CLA roster][].

[Individual Contributor License Agreement]: https://www.apereo.org/licensing/agreements

or

- [ ] This Contribution is under the terms of Individual and Corporate Contributor [License Agreement][](s) appearing in the [Apereo CLA roster][].

[License Agreement]: https://www.apereo.org/licensing/agreements

@coveralls
Copy link

coveralls commented Mar 20, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.06%) to 15.708% when pulling f878fb1 on require-icla into 1bccc2f on master.

@apetro apetro merged commit 4bc9c9a into master Mar 21, 2017
@apetro apetro deleted the require-icla branch March 21, 2017 05:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vertein vertein vertein approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apetro @coveralls @ChristianMurphy @vertein