Feature/show matching study in the list of dars #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wkirdp
commented
May 20, 2024
wkirdp
commented
- Add a dbGaPDataAccessRequest method to get matching studies
- Show matching studies in the DAR snapshot table
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
==========================================
+ Coverage 98.71% 98.73% +0.01%
==========================================
Files 300 300
Lines 23815 23850 +35
==========================================
+ Hits 23510 23549 +39
+ Misses 305 301 -4 ☔ View full report in Codecov by Sentry. |
This factory was previously not subclassed from the dbGaPDataAccessRequestFactory, so it tried to use a duplicate dbgap_dar_id, which caused integrity errors. Update the factory to subclass the main factory, which allows them to share the same Sequence counter for dbgap_dar_id.
amstilp
requested changes
May 21, 2024
The test_get_dbgap_application_pk_does_not_exist (and the equivalent post version) test is failing in CI, but I can't get it to fail locally.
… of study objects, not the short names Add linkify to matching studies
amstilp
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.