Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show an error message when auditing and CDSA group does not exist in app #211

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

amstilp
Copy link
Contributor

@amstilp amstilp commented Jul 6, 2023

When attempting to load the CDSAWorkspaceAudit or SignedAgreementAudit views and the CDSA group listed in the settings does not exist, show an error message instead of letting the view throw an exception.

amstilp added 2 commits July 5, 2023 16:48
Create a group with this specific name so we can override the name
of the group in a test.
In the CDSAWorkspaceAudit and SignedAgreementAudit views, the audits
require the ANVIL_CDSA_GROUP_NAME to exist in the app. Instead of
failing with a traceback/error in these views when the group doesn't
exist yet in the app, redirect back to the home page with a message.
@amstilp amstilp merged commit c5471a2 into main Jul 6, 2023
@amstilp amstilp deleted the feature/anvil-cdsa-group-error-message branch July 6, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant