-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
we used to have two path for rendering a frame #2028
Conversation
the one saving pngs was broken and not preserving pngs two paths are now unified this also fixes zoom on animations. fix #1845
How do we test it @doutriaux1 ? |
import vcs
import cdms2
import os
f=cdms2.open(os.path.join(vcs.sample_data,"clt.nc"))
s=f("clt",slice(0,12))
x=vcs.init(geometry=(800,600))
x.colormap = "AMIP"
x.plot(s)
x.animate.create(thread_it=1)
x.animate.zoom(2)
#x.animate.run()
raw_input("Press enter")
x.animate.save("crap.mp4") |
@doutriaux1 Do we have a test that failed before and passes with this change? |
nope. and animation testing are such a pain... I guess we could edit all of our exisiting animation test and force them to have a different colormap. |
@doutriaux1 Probably its enough if you only change one. If its easy to do it may be worth it - if not, its fine. |
LGTM 👍 but I didn't run testing. |
@doutriaux1 @danlipsa can we merge this now? |
the one saving pngs was broken and not preserving pngs
two paths are now unified
this also fixes zoom on animations.
fix #1845
This change is