Reenable autot_axis tests. Keep max Y to 500. #1967
Conversation
|
Data in |
|
@doutriaux1 @aashish24 Please review |
|
@danlipsa is it ok now on mac? The original comment said it crashes on mac, why is it not crashing anymore? |
| xSize = 400 | ||
| ySize = 800 | ||
| xSize = 250 | ||
| ySize = 500 | ||
| else: | ||
| xSize = 800 | ||
| ySize = 400 |
There was a problem hiding this comment.
don't you need 250 and 500 here as well?
There was a problem hiding this comment.
The problem way the Y size was bigger than the screen's Y. The way it is now works fine on the lowest resolution on my mac: 1024 x 640
There was a problem hiding this comment.
@danlipsa what is the logic of picking these hard-coded x and y size?
There was a problem hiding this comment.
@aashish24 I am making the window tall and narrow or long and thin so that ratio=autot is very different than the old behavior where the data is scaled with the window.
|
@doutriaux1 The tests worked on my mac because I had higher resolution. I switched to the lowest resolution and some of the tests failed - I fixed that by reducing the size of the images generated. I think the problem is related to |
|
@doutriaux1 @aashish24 ping |
|
LGTM 👍 |
danlipsa
force-pushed
the
reenable_autot_tests
branch
from
5cc5865 to
2dd2b35
Compare
No description provided.