fix #1141 #1142
Merged
fix #1141 #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chaosphere2112 do you feel like merging this one? |
| @@ -1008,8 +1008,8 @@ def plot2D(self,data1,data2,tmpl,gm,vtk_backend_grid=None,vtk_backend_geo=None): | |||
| #png.SetFileName("/git/uvcdat/Packages/vcs/Share/uvcdat_texture.png") | |||
| #T=vtk.vtkTexture() | |||
| #T.SetInputConnection(png.GetOutputPort()) | |||
| if isinstance(gm,isofill.Gfi): | |||
| mappers.append([mapper,]) | |||
| #if isinstance(gm,isofill.Gfi): | |||
There was a problem hiding this comment.
can we take it out. Why leave this code over?
There was a problem hiding this comment.
becauseit's code i left here for you guys when you will be doing the hatch/patterns, feel free to take it out.
There was a problem hiding this comment.
@aashish24 I was talking about the commented out lines above. I'm pretty sure these lines are not needed, we can take them out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these lines seems to be left over from tests for hatch/pattern and create the animation confusion
@aashish24 @chaosphere2112 please review and merge