-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue421 durack1 add seawater packages #1072
Issue421 durack1 add seawater packages #1072
Conversation
@doutriaux1, yep also seems like we've got these in the build queue too: |
@durack1 you need to make them dependent on python at least |
@doutriaux1 isn't that achieved in the gsw/seawater_deps.cmake files |
@doutriaux1 ok these both need numpy |
@doutriaux1 ok this one should be good to go - I fixed the dependencies |
set( GSW_PATCH 3 ) | ||
set( GSW_VERSION ${GSW_MAJOR}.${GSW_MINOR}.${GSW_PATCH} ) | ||
set( GSW_URL ${LLNL_URL} ) | ||
set( GSW_GZ python-gsw-${SEAWATER_VERSION}.tar.gz ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work. SEAWATER_VERSION is not set globally or in parent scope.
@durack1 please see my comment above. This branch needs some fix. |
@aashish24 yep thanks for that, it should now be fixed.. |
thanks. LGTM 👍 |
…kages Issue421 durack1 add seawater packages
@doutriaux1 take a look at this in response to #421