-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
running autot_title with setbgoutputdimensions leads to seg fault #1931
Comments
@danlipsa the diff is in branch |
@doutriaux1 On linux adding |
I would think doing any plot with these to set would result in a similar crash. |
@danlipsa yes there are two issues here |
No, I set the size at the beginning of the file: 800 by 400 (or 400 by 800). I think the problem is in foreground mode, when the window is resized by the OS and ends up a different size. |
@doutriaux1 I reduced the size of the image to make it 250 x 500 and reenabled the autot tests. Could you test those on you mac. |
@danlipsa will look into it. |
@doutriaux1 @aashish24 The problem here is: |
I don't understand. Didn't we use that for years and always ended up with the correct (in pixels) size for our baselines? Did this change recently? Anyhow I would say let's make it pixels by default. |
Maybe this API is more for the physical size of the output - at least this is what the documentation suggests. It has examples for output being US Legal and A4.. You can specify the size of the screen/off-screen buffer as the geometry parameter to init. So I would propose to leave it as it is and close this Issue. |
Other defaults: |
@aashish24 Do you have any input on this? |
@danlipsa like @doutriaux1 I am curious too. For testing we set the bg dimensions and I thought they are in pixels since the resultant image seems to be of correct size. My question is why we get right size on my machine if the unit is set to inches. I apologize if you already explain it but I couldn't find the clear answer for this question. |
@doutriaux1 @aashish24 grepping for this function shows that everywhere it is used has units='pixels' parameter added. Also the default value for the parameter units='inches' goes back at least to bb62d26 which is Dec 29 2011. The repo goes back to 29 10:06:12 2010 and the function did not exist then. |
We fix this by deprecating setbgoutputdimensions() and removing bgX and bgY. |
running script:
apple bug report:
The text was updated successfully, but these errors were encountered: