Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No docker error from WindNinja #2

Closed
micah-prime opened this issue Dec 6, 2018 · 1 comment
Closed

No docker error from WindNinja #2

micah-prime opened this issue Dec 6, 2018 · 1 comment
Assignees
@micah-prime
Labels
bug Something isn't working

Comments

@micah-prime
Copy link
Contributor

When WindNinja crashes the docker still exits successfully and does not throw an error.
@micah-prime micah-prime added the bug Something isn't working label Dec 6, 2018
@micah-prime micah-prime self-assigned this Dec 6, 2018
@scotthavens
Copy link
Contributor

While not tested, this should be fixed with PR #13. The Popen call that calls WindNinja_cli does a better job at catching errors from the command line. There is now a wait() that gets the return code of the Popen and will raise an exception if there is a return code that is not successful. There are a few tests in PR #13 to test some of the error catching but has not been tested in docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@micah-prime micah-prime

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scotthavens @micah-prime