Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch DB code to use the new Select api #173

Open
andrewj-brown opened this issue Oct 28, 2023 · 1 comment
Open

Switch DB code to use the new Select api #173

andrewj-brown opened this issue Oct 28, 2023 · 1 comment
Labels
enhancement update an existing command or cog for some new functionality infra-only due to access requirements (database stuff, usually), only infra can complete this

Comments

@andrewj-brown
Copy link
Member

According to the docs, the Query API of SQLAlchemy has been effectively replaced by the Select API, and is now effectively only a compatibility layer.

https://docs.sqlalchemy.org/en/20/orm/queryguide/query.html

As such, we should try to go through and move all our code to Select instead of Query.

I've tagged infra-only because this heavily involves the DB. However, I believe the vast majority of the changes don't actually need infra access - it will just need to be very thoroughly tested and have infra online at merge time in case something comes up.

@andrewj-brown andrewj-brown added enhancement update an existing command or cog for some new functionality infra-only due to access requirements (database stuff, usually), only infra can complete this labels Oct 28, 2023
@JamesDearlove
Copy link
Member

I think this is probably a low priority item just because there is no current plan to deprecate the existing API. However, definitely would be good when people go in and work on the couple of areas that use the database to update the queries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement update an existing command or cog for some new functionality infra-only due to access requirements (database stuff, usually), only infra can complete this
Projects
None yet
Development

No branches or pull requests

2 participants