Return code of 1 isn't counted as failure when requested to

[vs49688]

  AGENT [89fed8] [ INFO] Nimrod/G Agent, version 1.1.1 (x86_64-pc-linux-musl) starting up...
  AGENT [89fed8] [ INFO] UUID: ab4eb3e0-9a5e-41d8-816b-f0d6d1ef50f6
  AGENT [89fed8] [ INFO] Work Root "/tmp/nimrodg-localact-16645083851066122187/ab4eb3e0-9a5e-41d8-816b-f0d6d1ef50f6"...
  AGENT [89fed8] [ INFO] Registering POSIX signal handlers...
  AGENT [89fed8] [ INFO]   SIGINT...
  AGENT [89fed8] [ INFO]   SIGTERM...
  AGENT [89fed8] [ INFO]   SIGCHLD...
  AGENT [89fed8] [ INFO]   SIGHUP...
  AGENT [89fed8] [ INFO] Initialising LibreSSL 2.9.0...
  AGENT [89fed8] [ INFO] Initialising cURL 7.64.0
  AGENT [89fed8] [TRACE]   Supported protocols: [ftp, ftps, gopher, http, https, scp, sftp]
  AGENT [89fed8] [ INFO] Loaded 0 certificate(s)...
  AGENT [89fed8] [ INFO] Connecting to 'amqp://localhost:5672'...
  AGENT [89fed8] [ INFO] Connection established. Authenticating...
  AGENT [89fed8] [ INFO] Authentication successful!
  AMQPC [89fed8] [TRACE] Opening channel...
  AMQPC [89fed8] [TRACE] Setting channel to confirm...
  AMQPC [89fed8] [TRACE] Declaring queue...
  AMQPC [89fed8] [TRACE]   Got queue 'amq.gen-uJiz9YX-9XwtkAPmWMixcA'
  AMQPC [89fed8] [TRACE] Binding to broadcast exchange (amq.fanout)...
  AMQPC [89fed8] [TRACE] Binding to direct exchange (amq.direct)...
  AGENT [89fed8] [TRACE] Sending broker hello. Temporary UUID is ab4eb3e0-9a5e-41d8-816b-f0d6d1ef50f6
    NET [7f33a0a9fac0] [ INFO] Network Thread, starting up...
  AMQPC [7f33a0a9fac0] [TRACE] Received AMQP_BASIC_ACK_METHOD frame.
  AMQPC [7f33a0a9fac0] [TRACE] Message with delivery tag 1
  AGENT [89fed8] [TRACE] Broker ack'd hello.
  AMQPD [7f33a0a89ac0] [ INFO] AMQP Message Dispatcher, starting up...
  AMQPC [7f33a0a9fac0] [TRACE] Received AMQP_BASIC_DELIVER_METHOD frame.
  AGENT [89fed8] [TRACE] Processing message: agent.init({"type":"agent.init","uuid":"ab4eb3e0-9a5e-41d8-816b-f0d6d1ef50f6"})
  AGENT [89fed8] [TRACE] State change from WAITING_FOR_INIT -> IDLE.
  AMQPC [7f33a0a9fac0] [TRACE] Received AMQP_BASIC_DELIVER_METHOD frame.
  AGENT [89fed8] [TRACE] Processing message: agent.submit({"job":{"commands":[{"action":"fail","type":"onerror"},{"arguments":["/bin/false"],"program":"/bin/false","search_path":true,"type":"exec"}],"environment":{"NIMROD_AUTHTOKEN":"c675e2798f08c016111745dd84e20d0c","NIMROD_EXPNAME":"exp1","NIMROD_JOBINDEX":"1","NIMROD_JOBPATH":"exp1/1","NIMROD_JOBUUID":"1bd3cff9-4c79-4e49-adfd-a8a725e60bf6","NIMROD_TXURI":"file:///home/zane/.config/nimrod/experiments//exp1","NIMROD_VAR_jobindex":"1","NIMROD_VAR_jobname":"1","NIMROD_VAR_x":"x"},"index":1,"token":"ff50fe996eb243d9cf42bfa4365c3012","txuri":"file:///home/zane/.config/nimrod/experiments//exp1","uuid":"1bd3cff9-4c79-4e49-adfd-a8a725e60bf6"},"type":"agent.submit","uuid":"ab4eb3e0-9a5e-41d8-816b-f0d6d1ef50f6"})
  AGENT [89fed8] [TRACE] State change from IDLE -> IN_JOB.
    JOB [7f33a0a73ac0] [ INFO] [0] Executing command {"action":"fail","type":"onerror"}
    JOB [7f33a0a73ac0] [ INFO] [0] Setting error policy to FAIL
    JOB [7f33a0a73ac0] [ INFO] [0] Command execution status: 0
  AGENT [89fed8] [ERROR] Received child status update...
  AGENT [89fed8] [ERROR] [0] SUCCESS(0): Success
  AGENT [89fed8] [TRACE] State change from IN_JOB -> IN_JOB.
    JOB [7f33a0a5dac0] [ INFO] [1] Executing command {"arguments":["/bin/false"],"program":"/bin/false","search_path":true,"type":"exec"}
    JOB [7f33a0a5dac0] [TRACE] [1] Resolved program to ""/bin/false""
    JOB [7f33a0a5dac0] [TRACE] [1] Command arguments: ["/bin/false"]
  AMQPC [7f33a0a9fac0] [TRACE] Received AMQP_BASIC_ACK_METHOD frame.
  AMQPC [7f33a0a9fac0] [TRACE] Message with delivery tag 2
PROCESS [7f33a0a5dac0] [TRACE] Child forked to pid 19130
CONSOLE [89fed8] [ INFO] Caught SIGCHLD
PROCESS [89fed8] [TRACE] on_child_exit(19130, 256) called
    JOB [7f33a0a5dac0] [ INFO] [1] Command execution status: 1
  AGENT [89fed8] [ERROR] Received child status update...
  AGENT [89fed8] [ERROR] [1] SUCCESS(1): Success
  AGENT [89fed8] [TRACE] State change from IN_JOB -> IDLE.
  AMQPC [7f33a0a9fac0] [TRACE] Received AMQP_BASIC_ACK_METHOD frame.
  AMQPC [7f33a0a9fac0] [TRACE] Message with delivery tag 3
  AMQPC [7f33a0a9fac0] [TRACE] Received AMQP_BASIC_DELIVER_METHOD frame.
  AGENT [89fed8] [TRACE] Processing message: agent.lifecontrol({"operation":"terminate","type":"agent.lifecontrol","uuid":"ab4eb3e0-9a5e-41d8-816b-f0d6d1ef50f6"})
  AGENT [89fed8] [TRACE] State change from IDLE -> STOPPED.
  AGENT [89fed8] [ INFO] Main processor terminated, waiting for AMQP to exit...
  AMQPC [7f33a0a9fac0] [TRACE] Received AMQP_BASIC_ACK_METHOD frame.
  AMQPC [7f33a0a9fac0] [TRACE] Message with delivery tag 4
    NET [7f33a0a9fac0] [ INFO] Network Thread, signing off...
  AMQPD [7f33a0a89ac0] [TRACE] Caught future error: std::future_error: Broken promise.
  AMQPD [7f33a0a89ac0] [ INFO] This is AMQP Message Dispatcher, signing off...
  AGENT [89fed8] [ INFO] Nimrod/G Agent, version 1.1.1 (x86_64-pc-linux-musl) signing off...

[vs49688]

Not an agent bug apparently.

[vs49688]

Relevant bug is UQ-RCC/nimrodg#16