Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section collapse logic #131

Open
mattosborn opened this issue Aug 24, 2022 · 2 comments
Open

Section collapse logic #131

mattosborn opened this issue Aug 24, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@mattosborn
Copy link
Contributor

We need to think about section collapsing. Attached an example below of where the current logic is failing.

We should either:

  1. Keep iterating and hope we can reach a robust algorithm
  2. Allow a manual override, giving the content editor control of the collapse point
  3. Make collapsing completely manual so sections will only collapse if a collapse point is inserted.

Image

@mattosborn mattosborn added the enhancement New feature or request label Aug 25, 2022
@mattosborn
Copy link
Contributor Author

Thoughts on options 1-3 @xaquingv ?

@xaquingv
Copy link
Contributor

OMG! I had forgotten that we had talked about this and I brought this up again on Slack 😱

So the difference between 2 and 3 is that the default state is different, right?

  • Option 2 there's always a collapse point, and you choose to move around or remove it altogether.
  • Option 3 there's no collapse point unless you choose to insert one, right?

Given the current edits and production we're doing to the content. I'd choose option 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants