-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clover viewer #1815
Merged
Merged
Clover viewer #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the wrong PID if the PDF isn't the primary object
lfarrell
force-pushed
the
clover-viewer
branch
from
October 14, 2024 13:00
cf67f51
to
ba856bb
Compare
bbpennel
requested changes
Oct 14, 2024
search-solr/src/main/java/edu/unc/lib/boxc/search/solr/filters/HasViewerTypeFilter.java
Outdated
Show resolved
Hide resolved
search-solr/src/main/java/edu/unc/lib/boxc/search/solr/filters/HasViewerTypeFilter.java
Outdated
Show resolved
Hide resolved
web-access-app/src/main/java/edu/unc/lib/boxc/web/access/controllers/FullRecordController.java
Outdated
Show resolved
Hide resolved
web-access-app/src/main/java/edu/unc/lib/boxc/web/access/controllers/FullRecordController.java
Outdated
Show resolved
Hide resolved
web-common/src/main/java/edu/unc/lib/boxc/web/common/utils/DatastreamUtil.java
Show resolved
Hide resolved
...rvices-app/src/main/java/edu/unc/lib/boxc/web/services/processing/IiifV3ManifestService.java
Show resolved
Hide resolved
bbpennel
reviewed
Oct 15, 2024
search-solr/src/main/java/edu/unc/lib/boxc/search/solr/filters/HasValuesFilter.java
Outdated
Show resolved
Hide resolved
search-solr/src/main/java/edu/unc/lib/boxc/search/solr/filters/HasValuesFilter.java
Outdated
Show resolved
Hide resolved
bbpennel
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://unclibrary.atlassian.net/browse/BXC-4750