Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve our client-side error handling #762

Closed
NicMcPhee opened this issue Feb 13, 2022 · 1 comment
Closed

Improve our client-side error handling #762

NicMcPhee opened this issue Feb 13, 2022 · 1 comment
Labels
bug enhancement javascript Pull requests that update Javascript code

Comments

@NicMcPhee
Copy link
Member

NicMcPhee commented Feb 13, 2022

Our client-side error handling really isn't great, and that tends to lead to their error handling also not being great.

As an example, if you put a random ID in the URL for a user (e.g., http://localhost:4200/users/badID) you don't get any kind or error message or useful feedback – you just get a blank user page:

Blank user page when we provide a bad user ID

This is clearly not awesome. There should be some kind of message there that gives the user some info about what's going on, and probably some kind of console.log() message about the problem to help with debugging.

This will carry through to Lab 4 and the iteration template.

This may be related to #761, as turning on strict mode in TS will flag a lot of these issues for us.

@NicMcPhee NicMcPhee added bug enhancement javascript Pull requests that update Javascript code labels Feb 13, 2022
@NicMcPhee NicMcPhee changed the title Improve our error handling Improve our client-side error handling Feb 13, 2022
@NicMcPhee
Copy link
Member Author

I think this has been resolved by various commits over the past couple of years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement javascript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

1 participant