Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit (Karma) tests fail with --watch=false #519

Closed
NicMcPhee opened this issue Feb 15, 2021 · 2 comments
Closed

Unit (Karma) tests fail with --watch=false #519

NicMcPhee opened this issue Feb 15, 2021 · 2 comments

Comments

@NicMcPhee
Copy link
Member

ng test passes fine. ng test --watch=false passes all the tests, and then fails at the end with:

TOTAL: 22 SUCCESS
Chrome 88.0.4324.150 (Mac OS 10.15.7) ERROR
  Some of your tests did a full page reload!

No idea if this happened in the past, but I don't remember it and don't know why it's happening now. Some searching suggests this was a recent problem in Karma but should be fixed in the version we have in the Spring 2021 branch.

I don't know if this will interact badly with the GitHub Actions since they presumably only run the tests once?

@helloworld12321
Copy link

helloworld12321 commented Feb 16, 2021

After some testing, we were able to reproduce this issue on Mac, but not on Windows.

@NicMcPhee
Copy link
Member Author

This doesn't seem to happen anymore, even on Macs, so I assume that some updates somewhere made this go away. I'm going to close it for now, and we can re-open it if someone finds it happening again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants