Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSDAE code does not work since v3.0 #3169

Closed
gbcolborne opened this issue Jan 13, 2025 · 1 comment · Fixed by #3137
Closed

TSDAE code does not work since v3.0 #3169

gbcolborne opened this issue Jan 13, 2025 · 1 comment · Fixed by #3137
Labels
bug Something isn't working enhancement New feature or request

Comments

@gbcolborne
Copy link

Just a head's up: the code example at https://github.com/UKPLab/sentence-transformers/blob/master/examples/unsupervised_learning/TSDAE/README.md and the script https://github.com/UKPLab/sentence-transformers/blob/master/examples/unsupervised_learning/TSDAE/train_tsdae_from_file.py no longer run, because of the deprecated method model.fit. They do run with model.old_fit, for now.
@tomaarsen tomaarsen added bug Something isn't working enhancement New feature or request labels Jan 16, 2025
@tomaarsen
Copy link
Collaborator

Hello!

Thank you for the reminder. #3137 by @JINO-ROHIT and myself resolves this.
I'll merge it soon, but you can already try out those scripts.

I used it to train:

  • Tom Aarsen

@tomaarsen tomaarsen linked a pull request Jan 17, 2025 that will close this issue
Update TSDAE examples with SentenceTransformerTrainer #3137
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update TSDAE examples with SentenceTransformerTrainer JINO-ROHIT/sentence-transformers
2 participants
@gbcolborne @tomaarsen