feat(APIM-609): companies house - extend returned fields #1089
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
In order for Companies House to be consumed by other products/services, the integration needs to return some additional fields.
Note: unfortunately, some methods in the Companies House service do not have unit test coverage as they are private methods. I would like to add unit tests for all private methods (likely needing to make them public or extracted into helper functions), but this would be a bigger change than introducing additional fields.
Resolution ✔️
CompaniesService
to return the following additional data:accounts
objectdateOfCreation
registeredAddress.careOf
registeredAddress.organisationName
registeredAddress.premises
registeredAddress.region