Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(APIM-609): companies house - extend returned fields #1089

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ttbarnes
Copy link

@ttbarnes ttbarnes commented Dec 6, 2024

Introduction ✏️

In order for Companies House to be consumed by other products/services, the integration needs to return some additional fields.

Note: unfortunately, some methods in the Companies House service do not have unit test coverage as they are private methods. I would like to add unit tests for all private methods (likely needing to make them public or extracted into helper functions), but this would be a bigger change than introducing additional fields.

Resolution ✔️

  • Update Companies House types.
  • Update CompaniesService to return the following additional data:
    • accounts object
    • dateOfCreation
    • registeredAddress.careOf
    • registeredAddress.organisationName
    • registeredAddress.premises
    • registeredAddress.region

Copy link

sonarcloud bot commented Dec 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant