Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orca breaks with toolz>=0.11, because tz.compatibility.zip is depreciated #50

Closed
MaxBo opened this issue Sep 29, 2020 · 3 comments
Closed
Assignees

Comments

@MaxBo
Copy link

MaxBo commented Sep 29, 2020

if toolz>=0.11 is installed, an error is raised in orca.py in line 940,

labels_map = dict(tz.concatv( tz.compatibility.zip(names[:offset], names[:offset]), tz.compatibility.zip(names[offset:], expressions)))
because tz.compatibility.zip does is not supported any more from toolz>=0.11.
With tools==0.10 it still works.

You could either switch to the standard library zip instead of
tz.compatibility.zip , or if you need this for compability reasons with python 2, pin the toolz-version to 0.10.

@smmaurer
Copy link
Member

Hi @MaxBo, thanks for catching this! It should be fixed now in the toolz-patch branch, and we'll put out a release as soon as we do a little more testing.

Here's the code on the toolz side, for future reference: https://github.com/pytoolz/toolz/blob/master/toolz/compatibility.py

Incidentally, it looks like toolz.compatibility is just supposed to raise a DeprecationWarning beginning in v0.11, which is what happens on my Mac. But in one of our Linux environments it raised an error, likely the same as what's described above -- an AttributeError on importing tlz.compatibility. The fix I implemented is to switch to the standard library zip, which should solve things either way.

@cvanoli
Copy link

cvanoli commented Oct 30, 2020

I've encountered the same issue. Hope this fix gets pushed in soon. Thanks Sam!

@smmaurer
Copy link
Member

Resolved in v1.5.4 release / PR #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants