181 hdf5 io #193
Closed
181 hdf5 io #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcunliffe
commented
Nov 29, 2022
| /** Common to both constructors: open/create the file and set file_ to point to it. */ | ||
| void _open(); | ||
| std::string filename_; /**< The file name. */ | ||
| HDF5FileMode mode_; /**< The I/O mode: default is to create non-existing. */ |
There was a problem hiding this comment.
Suggested change
| HDF5FileMode mode_; /**< The I/O mode: default is to create non-existing. */ | |
| HDF5FileMode mode_; /**< The I/O mode: default is to open in read-only. */ |
samcunliffe
force-pushed
the
181-hdf5-io
branch
2 times, most recently
from
3e8d84b
to
e6e4c58
Compare
Co-authored-by: Mosè Giordano <[email protected]> Co-authored-by: Will Graham <[email protected]>
Move the test_hdf5 function out of openandorder. Remove call to example function. Correct doc comment.
Basic class structure and some failing tests for TDD.
samcunliffe
force-pushed
the
181-hdf5-io
branch
from
e6e4c58
to
44e775d
Compare
samcunliffe
added
the
technical
|
Closing this PR, but keeping the branch around. |
Deleted branches can always be restored at any time if really needed. |
This was referenced May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Draft] of adding hdf5. Tests should fail because: TDD. No functional code in these commits.