Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a github action to build macos #78

Closed
samcunliffe opened this issue Sep 5, 2022 · 1 comment · Fixed by #85
Closed

Add a github action to build macos #78

samcunliffe opened this issue Sep 5, 2022 · 1 comment · Fixed by #85
Assignees
Labels
enhancement New feature or request technical Technical and meta issues, not related to physics but infrastructure. testing Adding or requesting more test coverage

Comments

@samcunliffe
Copy link
Member

[Placeholder issue, we might want to reject]

We are currently building windows and linux, worth to add macos? Mention this because @samcunliffe had some strange issues compiling. If this is a workflow we expect of future users/students, we probably want to test it.

On the other hand, perhaps this is a waste of time.

@samcunliffe samcunliffe added enhancement New feature or request technical Technical and meta issues, not related to physics but infrastructure. testing Adding or requesting more test coverage labels Sep 5, 2022
@giordano
Copy link
Member

giordano commented Sep 5, 2022

The first commit in #48 added macOS as well, but then we gave up on that. I think something wasn't quite working but we didn't push it because it wasn't high priority, but I don't remember the details.

@samcunliffe samcunliffe linked a pull request Sep 7, 2022 that will close this issue
@samcunliffe samcunliffe self-assigned this Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request technical Technical and meta issues, not related to physics but infrastructure. testing Adding or requesting more test coverage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants