Is it time to remove or replace crate-ci/typos?

[paddyroddy]

Short Description

Following a recent change, crate-ci/typos is causing many false positives. For now, I have commented them out #129. We previously had https://github.com/codespell-project/codespell. Maybe something else or remove altogether?

Evidence/Steps to Reproduce

No response

Acceptance Criteria/Expected Behaviour

No response

Details

No response

Resolution

No response

[paddyroddy]

v1.24.4 seems to have fixed most of the issues? 🤞

[ruaridhg]

I don't know if this is related, but I'm getting a frustrating linting error due to US/UK spelling since it wants to correct the US spelling of synchronize which is actually what is needed in the test.yml:

typos....................................................................Failed
- hook id: typos
- exit code: 2

error: `synchronize` should be `synchronise`
  --> .github/workflows/tests.yml:15:9
   |
15 |       - synchronize
   |         ^^^^^^^^^^^
   |

[ruaridhg]

I don't know if this is related, but I'm getting a frustrating linting error due to US/UK spelling since it wants to correct the US spelling of synchronize which is actually what is needed in the test.yml:

typos....................................................................Failed
- hook id: typos
- exit code: 2

error: `synchronize` should be `synchronise`
  --> .github/workflows/tests.yml:15:9
   |
15 |       - synchronize
   |         ^^^^^^^^^^^
   |

Updating my .pre-commit-config.yaml with the latest version worked for mirsg-upgrades:

repos:
  - repo: https://github.com/UCL-MIRSG/.github
    rev: v0.107.0

[paddyroddy]

I don't know if this is related, but I'm getting a frustrating linting error due to US/UK spelling since it wants to correct the US spelling of synchronize which is actually what is needed in the test.yml:

typos....................................................................Failed
- hook id: typos
- exit code: 2

error: `synchronize` should be `synchronise`
  --> .github/workflows/tests.yml:15:9
   |
15 |       - synchronize
   |         ^^^^^^^^^^^
   |

Yeah 100% related, as I said above typos has become a bit trigger happy. If nothing else we might want to remove this line

.github/precommit/mirsg-hooks.yaml

Line 79 in ecd8fdc

# - --locale=en-gb

[paddyroddy]

I think turning off British English (sad times) has solved this. It is very handy, so let's keep it.