Friend Group data structure and accompanying functions from COMP0233 session 14/10/2024 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 14, 2024 11:07
…the example (changed the order of the relationships)
…t least one friend
am1520x
changed the title
gpwhs
reviewed
Oct 17, 2024
There was a problem hiding this comment.
good use of list comprehensions in places, but you can probably use them more instead of using append
use max() etc instead of creating lists in memory
check bidirectional relationships stay symmetrical on removal etc
add error handling + wrap in if name == "main":
check how many times you're looping through my_group? you might be able to bring it down
add error handling
add if name == "main"
added 2 commits
October 20, 2024 20:00
…quest. Replaced all append() operations with list comprehensions for more efficient and concise code, used max() directly within loops instead of storing values in intermediate lists, added bidirectional relationship handling in the forget_person function (so that both people have the relationship removed), and added error handling and main block.
…week 4 pre-lecture task 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Answers UCL-COMP0233-24-25/RSE-Classwork #5,#6,#7