improving check_pop_data()
#207
Conversation
d-morrison
added
API
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
| } | ||
|
|
||
| missing_age <- is.element(attributes(pop_data)$age_var, names(pop_data)) | ||
|
|
||
| if (!missing_age) { | ||
| cli::cli_abort(message = paste("Argument `pop_data` is missing column", attributes(pop_data)$age_var, "(age, in years)")) | ||
| "Argument {.arg pop_data} is missing column {.var {attributes(pop_data)$age_var}} (age, in years)" %>% | ||
| cli::cli_abort(class = "missing-var") |
There was a problem hiding this comment.
Do we have an exhaustive list of error classes?
| "Provide a `data.frame()` with cross-sectional serology data per antigen isotype." | ||
| )) | ||
| cli::cli_abort( | ||
| class = "not a data.frame", |
There was a problem hiding this comment.
Do we communicate all types of error classes in the package?
There was a problem hiding this comment.
@chrisorwa see my other comment; I don't think so, since they aren't typically visible to users of our package.
@chrisorwa good question; I'm still coming up to speed on error classes, but as far as I can tell, they are not part of the API - we create them ourselves for our own internal use in unit tests, instead of using the |
improving error messages, added test