Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subdomain matching not working as expected #181

Open
cryolithic opened this issue Nov 29, 2024 · 3 comments
Open

Subdomain matching not working as expected #181

cryolithic opened this issue Nov 29, 2024 · 3 comments
Labels
bug Something isn't working Fixed/Completed Commits related to this are in master, if the issue is still open, it's yet to be released
Milestone

Comments

@cryolithic
Copy link

I have a link to https://sub2.sub.domain.com/url/to/page.html
Initially I tried a domain rule for *.domain.com which did not match
I tried the following regexes:
.*\.domain.com did not work
.*\.domain\.com/.* did not work
even .* did not work.
image

@cryolithic
Copy link
Author

Additionally when I added the full domain under domain, the test was successful, but when clicking a link to that, it still brought up the chooser interface, rather than the browser I chose for the ruleset.

@U-C-S
Copy link
Owner

U-C-S commented Nov 29, 2024

Thanks for reporting. Found that code is not identifying the Rule Type correctly.

@U-C-S U-C-S added the bug Something isn't working label Nov 29, 2024
@U-C-S U-C-S added this to the v0.10 milestone Nov 29, 2024
@U-C-S U-C-S closed this as completed in 2170c8b Nov 29, 2024
@U-C-S U-C-S reopened this Nov 29, 2024
@U-C-S
Copy link
Owner

U-C-S commented Nov 29, 2024

I have a link to https://sub2.sub.domain.com/url/to/page.html
Initially I tried a domain rule for *.domain.com which did not match

Currently domain rule doesn't support any pattern matching syntax. So the only match in this case would be for sub2.sub.domain.com for Domain rule type.

I want to come back to improving and fixing various issues around Rule Matching soon. all options have atleast some known issue (except for Regex)

@U-C-S U-C-S added the Fixed/Completed Commits related to this are in master, if the issue is still open, it's yet to be released label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed/Completed Commits related to this are in master, if the issue is still open, it's yet to be released
Projects
None yet
Development

No branches or pull requests

2 participants