Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass github user/project from options #753

Closed
egoist opened this issue Apr 17, 2018 · 7 comments
Closed

Allow to pass github user/project from options #753

egoist opened this issue Apr 17, 2018 · 7 comments
Labels
enhancement Improved functionality wontfix Declining to implement

Comments

@egoist
Copy link

egoist commented Apr 17, 2018

Currently it's using the output of:

let out = <ShellJS.ExecOutputReturnValue> ShellJS.exec('git ls-remote --get-url', {silent: true});

However it might be not defined in a continuous deployment environment like netlify.com so the link to source file isn't working.

A flag like --gitRemote https://github.com/user/project would help.

@egoist
Copy link
Author

egoist commented Jan 29, 2019

Here's a workaround if you're using Netlify, run following command first in your build command:

git remote add origin [email protected]:$user/$repo.git

@aciccarello aciccarello added enhancement Improved functionality help wanted Contributions are especially encouraged good first issue Easier issue for first time contributors labels Jan 31, 2019
@aciccarello
Copy link
Collaborator

Sounds like a good suggestion. PRs are welcome. Should be able to add an option in that GitHubPlugin file.

@artentica
Copy link
Contributor

Seems to already been implemented => #843
@aciccarello

@aciccarello
Copy link
Collaborator

@artentica That adds support for different github host names. I don't believe it supports different user logins though.

@artentica
Copy link
Contributor

In seing the title i undestand it correspond to this:


Wich is only few month old

@aciccarello
Copy link
Collaborator

True, I misunderstood this issue. I think the remaining issue is that that is pulled from git ls-remote --get-url. However, looking at the workaround @egoist posted, I do think that we should be able to close this.

@aciccarello aciccarello added wontfix Declining to implement and removed good first issue Easier issue for first time contributors help wanted Contributions are especially encouraged labels Feb 8, 2019
@domoritz
Copy link

I don't think setting the remote is always enough. The issue is that different users may have different setups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improved functionality wontfix Declining to implement
Projects
None yet
Development

No branches or pull requests

4 participants