Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No footer in the default theme and renderhooks #2532

Closed
xuhdev opened this issue Mar 24, 2024 · 2 comments
Closed

No footer in the default theme and renderhooks #2532

xuhdev opened this issue Mar 24, 2024 · 2 comments
Labels
enhancement Improved functionality

Comments

@xuhdev
Copy link
Contributor

xuhdev commented Mar 24, 2024

Search Terms

footer, theme

Problem

No footer in the default theme. This makes things like copyright notice, privacy notice (e.g., for those who use Google analytics), logo that commonly appear at the footer have no good place to go.

Suggested Solution

Add a footer to the default theme and add footer.{begin,end} render hooks.

@xuhdev xuhdev added the enhancement Improved functionality label Mar 24, 2024
@xuhdev
Copy link
Contributor Author

xuhdev commented Mar 24, 2024

To clarify, when I say footer, I meant a footer that uses the footer tag. Currently, with the default theme, the "Generated by TypeDoc" text is not enclosed by a footer tag, and appending a footer tag using body.end render hooks would cause somewhat unnatural results.

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Mar 24, 2024

The "Generated by TypeDoc" probably ought to be in a footer tag

@Gerrit0 Gerrit0 closed this as completed in b533004 Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improved functionality
Projects
None yet
Development

No branches or pull requests

2 participants