Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine similar converter tests + lint test files #1156

Closed
Gerrit0 opened this issue Dec 27, 2019 · 1 comment
Closed

Combine similar converter tests + lint test files #1156

Gerrit0 opened this issue Dec 27, 2019 · 1 comment
Labels
good first issue Easier issue for first time contributors help wanted Contributions are especially encouraged

Comments

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Dec 27, 2019

Every directory in src/test/converter is a separate test. Even for trivial tests like the variable test that only have 3 lines, we have to re-start the TypeScript compilation, so these tests take at least a couple seconds. Quite a few of these tests could be combined. I think we should be able to get the test running time down to under a minute, I'd really like to get it down to 30 seconds or less, but I'm not sure if that's possible without sacrificing test organization.

Further, most of the test files currently do not pass TSLint rules, when rebuilding the tests, this should be fixed to avoid IDE warnings.

@Gerrit0 Gerrit0 added help wanted Contributions are especially encouraged good first issue Easier issue for first time contributors code health labels Dec 27, 2019
@Gerrit0 Gerrit0 changed the title Combine similar tests + lint test files Combine similar converter tests + lint test files Dec 27, 2019
@Gerrit0
Copy link
Collaborator Author

Gerrit0 commented Jan 13, 2020

Resolved by 1fd2185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Easier issue for first time contributors help wanted Contributions are especially encouraged
Projects
None yet
Development

No branches or pull requests

1 participant