Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable --type-check option by default again #493

Closed
sanex3339 opened this issue Dec 15, 2017 · 4 comments
Closed

Enable --type-check option by default again #493

sanex3339 opened this issue Dec 15, 2017 · 4 comments

Comments

@sanex3339
Copy link

Hi. After 4.0.0 version, i got many problems with --type-check option that disabled by default.
Now in all mocha tests (running with CLI or with WebStorm IDE Interface) i should add TS_NODE_TYPE_CHECK environment variable, because without that all tests are failing due to typescript compile errors.

It is possible to revert back this change or add more global way (through config file) to enable typeCheck option?

@stelcheck
Copy link
Contributor

stelcheck commented Dec 20, 2017

You might want to see #412 - you should be able to use the register specified there.

It seems that type-check was disabled so that the default behavior may remain fast.

@blakeembrey
Copy link
Member

The things you ask for already exist, you just need to check the README. There's config options listed in https://github.com/TypeStrong/ts-node#configuration-options and there's also ts-node/register/type-check defined in https://github.com/TypeStrong/ts-node#programmatic. Feel free to open a PR if these docs are inadequate.

@blakeembrey
Copy link
Member

because without that all tests are failing due to typescript compile errors.

What does this mean? It's failing because of TypeScript compile errors when there's no type checking?

@sanex3339
Copy link
Author

thank you. ts-node/register/type-check works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants