Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: replace uses of os.EOL with grunt.util.linefeed #199

Closed
DavidRigglemanININ opened this issue Jan 20, 2015 · 4 comments
Closed
Labels

Comments

@DavidRigglemanININ
Copy link
Contributor

Currently, this plugin uses os.EOL as the new line character when generating new files (such as in reference.ts). This can cause problems in cross platform development and in source control management as the generated reference files will be different depending on whether they were generated on Windows or Linux/Mac. Grunt has the ability to optionally specify the line feed character (still defaults to os.EOL) with grunt.util.linefeed (gruntjs/grunt-contrib-concat#20). To take advantage of this, all you would need to do is update the references to os.EOL. I can do this work and create a pull request, but I want to make sure you are OK with this before spending the time (there are 14 references throughout the entire code base)

@nycdotnet
Copy link
Contributor

Good point. This would need to be referenced in the documentation as well. If you want to submit a PR we'd be happy to accept it.

@DavidRigglemanININ
Copy link
Contributor Author

Should I update the files in tasks-internal? Reading comments from another issue, it looks like tasks-internal is used as the internal compiler you use to turn the grunt-ts typescript into javascript

@basarat
Copy link
Member

basarat commented Jan 20, 2015

Should I update the files in tasks-internal?

no need. Your understanding is correct. It will automatically get updated the next time we run grunt update to update the LKG. Looking forward to the PR!

@nycdotnet
Copy link
Contributor

Merged. Thanks very much @DavidRigglemanININ . Great first PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants