Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fake Node Sentence #866

Closed
smedilol opened this issue Mar 9, 2018 · 5 comments
Closed

Remove fake Node Sentence #866

smedilol opened this issue Mar 9, 2018 · 5 comments
Assignees
@mayanje
Labels
Codegen Won't Do
Milestone
v1.4-Global-stora...

Comments

@smedilol
Copy link
Contributor

smedilol commented Mar 9, 2018

Sentence Node is used for code generation only.
We should remove it and use a better technique to generate our code.
This will impact Razor template.
@smedilol smedilol added this to the Version X - Node/Razor refactoring milestone Mar 9, 2018
@mayanje
Copy link
Contributor

mayanje commented Jan 9, 2019

Based on the work made with #1028, we can now start reviewing all skeleton templates

@mayanje
Copy link
Contributor

mayanje commented Feb 5, 2019

Can we move this issue in v1.4 ?

@smedilol
Copy link
Contributor Author

smedilol commented Feb 5, 2019

Yes, that's not urgent

@mayanje
Copy link
Contributor

mayanje commented Feb 5, 2019

ok to move it to v1.4.

@smedilol smedilol modified the milestones: v1.4.1, v1.4.2 Aug 29, 2019
@smedilol
Copy link
Contributor Author

Following an internal discussion, Sentence node is mandatory for Control flow / data flow.
We must keep it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayanje mayanje

Labels
Codegen Won't Do
Projects
None yet
Milestone
v1.4-Global-storage / type and proced...
Development

No branches or pull requests
2 participants
@smedilol @mayanje