Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Mobile editor mocks getPostType resolution #3

Conversation

dcalhoun
Copy link

What?

Fix failing mobile editor unit tests.

Why?

The erroneous test failures are misleading.

How?

The mobile editor only supports the post-only rendering mode, so we presume a resolved getPostType selector to unblock editor rendering. This is necessary as the editor provider awaits post type resolution before rendering the entirety of the editor.

Testing Instructions

N/A, no user-facing changes.

Testing Instructions for Keyboard

N/A, no user-facing changes.

Screenshots or screencast

N/A, no user-facing changes.

The mobile editor only supports the `post-only` rendering mode, so we
presume a resolved `getPostType` selector to unblock editor rendering.
This is necessary as the editor provider awaits post type resolution
before rendering the entirety of the editor.
@dcalhoun dcalhoun marked this pull request as ready for review November 15, 2024 21:38
@dcalhoun
Copy link
Author

@fabiankaegy this is ready for review and merge. It should fix the failing mobile editor automated tests.

Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dcalhoun <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code here look good to me :)

And I ran the tests locally and can confirm they are also fixed for me there 🎉

@fabiankaegy fabiankaegy merged commit ec543c5 into TylerB24890:feature/post-type-rendering-mode-58038 Nov 15, 2024
53 of 62 checks passed
@fabiankaegy fabiankaegy deleted the test/mobile-editor-mocks-get-post-type-resolution branch November 15, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants