Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion with reanimate-svg #23

Open
yairchu opened this issue Apr 3, 2020 · 3 comments
Open

Confusion with reanimate-svg #23

yairchu opened this issue Apr 3, 2020 · 3 comments

Comments

@yairchu
Copy link

yairchu commented Apr 3, 2020

I was going to offer PR for svg-tree, but before doing so I reviewed existing PRs and forks, and noticed the https://github.com/reanimate/reanimate-svg fork (preferably I'd file this issue there but it has GitHub issues disabled).

It would be nice to know what are the differences between the two. Preferably reanimate-svg would explain it (as it initiated the fork) but lacking that, an explanation in svg-tree's readme would clear things up!

@georgefst
Copy link

I'm guessing the author got frustrated with issues and PRs not being responded to and started the fork because they needed to iterate faster.

I'd also like to know what's going on, as I'm trying to decide which of the two to use for a new project. reanimate-svg looks like it makes several improvements, but I'm wary of relying on a library that doesn't have an issue tracker.

@lemmih @Twinside Is any reconciliation likely?

@georgefst
Copy link

Ok turns out there is an issue tracker, the link on Hackage was just outdated.

reanimate/reanimate-svg#25

@lemmih
Copy link

lemmih commented Dec 30, 2020

I forked reanimate-svg because it is vital to reanimate and I need to be able to make breaking changes without having to ask permission.

If development picks up again for svg-tree then I'd definitely pull in the improvements. Might not be possible since reanimate-svg has changed quite a bit, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants