Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cargo change detection in the runtime #12

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

jelmansouri
Copy link
Contributor

  • Fix change detection for by setting the full path of rs and lib file, otherwise the build script gets evaluated at each run, the problem arises when the crate using the runtime is down the dependency graph causing all it's children to be compiled.
  • Using target instead of host, to build for cross compilation scenarios (not tested)

@jelmansouri
Copy link
Contributor Author

If the change make sense can a new patch version be generated with this ?

@Twinklebear
Copy link
Owner

Thanks @jelmansouri , I think this looks good! I think the move to use TARGET instead of HOST is probably right for cross-compilation, and makes me think should actually change the code here https://github.com/Twinklebear/ispc-rs/blob/master/compile/src/lib.rs#L355 to use the set target instead as well (for cross compiling). I'm not entirely sure cross-compilation works in ispc-rs, it's not something I've tested out.

@Twinklebear Twinklebear merged commit b16ef27 into Twinklebear:master Feb 17, 2022
@Twinklebear
Copy link
Owner

I'll aim to put out a new release tomorrow with this + some tweaks for arm systems in it

@jelmansouri
Copy link
Contributor Author

I'll aim to put out a new release tomorrow with this + some tweaks for arm systems in it

Thanks a lot! I'll try to test out cross compilation to make sure it works. My project is planning to start building the windows-msvc target from linux soon.

@Twinklebear
Copy link
Owner

That's good to know, right now ispc-rs doesn't pass the --target-os flag through so I think cross-OS compilation wouldn't quite work. I can add that in before the release so it might work, let me know how it goes!

@Twinklebear
Copy link
Owner

This is now out in 1.0.11! Let me know how it works (or doesn't :) )

@jelmansouri
Copy link
Contributor Author

This is now out in 1.0.11! Let me know how it works (or doesn't :) )

It works! Thanks!

@jelmansouri
Copy link
Contributor Author

I can confirm that cross linking works when using a prebuild kernel, I'll try building the kernel next and will report back/fix the issue! Thanks @Twinklebear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants