Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs: How Turing implements AbstractMCMC #477

Open
BenjaminJCox opened this issue Feb 6, 2023 · 0 comments
Open

Update docs: How Turing implements AbstractMCMC #477

BenjaminJCox opened this issue Feb 6, 2023 · 0 comments

Comments

@BenjaminJCox
Copy link

BenjaminJCox commented Feb 6, 2023

The documentation makes numerous references to functions that are not used by the current version of AbstractMCMC, and contains an outdated extension of assume (potentially among other things). It seems as though this tutorial has not been kept up to date, and I am unsure as to whether it is correct anymore.

I have noticed that:

  • ISState is defined here despite not being present in is.jl
  • No mention is made of DynamicPPL.initialstep, DynamicPPL.initialsampler
  • DynamicPPL.assume and DynamicPPL.observe are extended differently in the docs than in is.jl
  • lines 27-29 of is.jl are devoid of explanation in the docs

This is confusing as someone looking to contribute, but I anticipate that someone more familiar with the relevant code would easily be able to correct this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant